feat: check credential validity against signature expiration - #772
Merged
Conversation
Contributor
Author
|
Note I only changed the AWS backend because I don't know the behavior of the other backends very well. |
When signing requests, we currently only check that the credential is *currently* valid, but on some backends (for example AWS), the signature lifetime is capped to the credential lifetime. In those situations, we need to refresh credentials instead of using the cached ones. This is still best-effort; if the minimum expiry of the credential is less than the desired expiry of the signature, there's nothing we can do. This introduces a new method to `SigningCredential`, `is_valid_at`, with a default impl so the change is non-breaking.
Member
|
Thank you for this change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When signing requests, we currently only check that the credential is currently valid, but on some backends (for example AWS), the signature lifetime is capped to the credential lifetime. In those situations, we need to refresh credentials instead of using the cached ones.
This is still best-effort; if the minimum expiry of the credential is less than the desired expiry of the signature, there's nothing we can do. We could change the signature of
is_valid_atto return a potential error if the requested expiry is impossible to fulfill, up to you.Fixes #771.