Skip to content

Set shared capability of Mini Moka and OPFS#7856

Open
QazCetelic wants to merge 2 commits into
apache:mainfrom
QazCetelic:feat/shared-capability-unspecified
Open

Set shared capability of Mini Moka and OPFS#7856
QazCetelic wants to merge 2 commits into
apache:mainfrom
QazCetelic:feat/shared-capability-unspecified

Conversation

@QazCetelic

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #7855.

Rationale for this change

The shared capability flag is set for all other services, but is missing for OPFS and Mini Moka.
The choice to mark one shared and the other not is based on Xuanwo's definition in this comment.

What changes are included in this PR?

  1. Set mini moka backend shared capability to false
  2. Set opfs backend shared capability to true

Are there any user-facing changes?

opfs shared capability becomes true instead of defaulting to false.

AI Usage Statement

No AI used

@QazCetelic QazCetelic requested a review from Xuanwo as a code owner July 5, 2026 07:16
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 5, 2026
write_can_empty: true,
delete: true,
list: true,
shared: false,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false doesn't need to be set.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I decided to also set it because all other services also explicitly set it to false.

I can add a commit to remove those lines if you'd prefer avoiding setting implicitly defined capabilities.

@QazCetelic QazCetelic force-pushed the feat/shared-capability-unspecified branch from b5503c5 to 2fbe046 Compare July 8, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shared capability not specified for opfs and mini_moka

2 participants