Set shared capability of Mini Moka and OPFS#7856
Conversation
| write_can_empty: true, | ||
| delete: true, | ||
| list: true, | ||
| shared: false, |
There was a problem hiding this comment.
Yes, I decided to also set it because all other services also explicitly set it to false.
opendal/core/services/dashmap/src/backend.rs
Line 101 in 4f1df12
opendal/core/services/moka/src/backend.rs
Line 205 in 4f1df12
opendal/core/services/persy/src/backend.rs
Line 139 in 4f1df12
opendal/core/services/redb/src/backend.rs
Line 151 in 4f1df12
opendal/core/services/rocksdb/src/backend.rs
Line 101 in 4f1df12
opendal/core/services/sled/src/backend.rs
Line 125 in 4f1df12
opendal/core/services/sqlite/src/backend.rs
Line 191 in 4f1df12
I can add a commit to remove those lines if you'd prefer avoiding setting implicitly defined capabilities.
b5503c5 to
2fbe046
Compare
Which issue does this PR close?
Closes #7855.
Rationale for this change
The shared capability flag is set for all other services, but is missing for OPFS and Mini Moka.
The choice to mark one shared and the other not is based on Xuanwo's definition in this comment.
What changes are included in this PR?
Are there any user-facing changes?
opfsshared capability becomes true instead of defaulting to false.AI Usage Statement
No AI used