fix(bindings/python): fix sized File.readline - #8169
Merged
Conversation
Xuanwo
marked this pull request as ready for review
August 27, 2026 06:09
PsiACE
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8159.
Rationale for this change
File.readline(size)initializes its destination buffer withsizezero bytes.BufRead::read_untilappends the line after those bytes, and the implementation then truncates the buffer using only the appended length. As a result, sized reads return zero bytes while advancing the file cursor.What changes are included in this PR?
Read sized lines into an empty buffer while retaining the existing
take(size)limit. Add a synchronous regression test againstio.BytesIOthat covers partial lines, newline boundaries, zero-sized reads, cursor progression, and EOF.Are there any user-facing changes?
Yes.
File.readline(size)now returns the bytes read from the file, up to the requested size, instead of zero-filled data.AI Usage Statement
AI materially assisted with root-cause analysis, implementation, regression-test construction, and local validation. Validation used the memory backend through the shared blocking reader path; the full remote-service behavior matrix was not run.