Skip to content

Conversation

@FJCC
Copy link
Contributor

@FJCC FJCC commented Feb 8, 2021

Checking out the first three sub-documents of Getting Started. These include Jean's changes and suggestions

Copy link

@orcmid orcmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit has not been specified against a known branch.

There needs to be some clarification on how binary files in pushes can be opened for review.

Also, if the intention is to create a branch, there seems to be something missing.
oooDoc-2012-02-08-0951-GettingStartedPull-FC

Copy link

@orcmid orcmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the .ods file is not downloadable from the pull request, so meaningful review (although probably not needed) is not possible.

This could be either a GitHub or a browser or a permissions problem. Need to sort that out.

@orcmid
Copy link

orcmid commented Feb 8, 2021

I did manage to synchronize after figuring out that the Review folder is on branch Getting-Started-Guide.

I recommend that the CheckOutSheet.ods file be changed to a table in Markdown (i.e. CheckOutStatus.md). This will allow viewing in a browser and also show changes and diffs about them.

@knmc
Copy link
Contributor

knmc commented Feb 8, 2021 via email

@knmc
Copy link
Contributor

knmc commented Feb 8, 2021 via email

@knmc
Copy link
Contributor

knmc commented Feb 9, 2021

Looks good, merging .

@knmc knmc closed this Feb 9, 2021
@knmc knmc reopened this Feb 9, 2021
@knmc knmc merged commit a1279fb into apache:Getting-Sarted-Guide Feb 9, 2021
@knmc knmc linked an issue Feb 12, 2021 that may be closed by this pull request
@knmc knmc added the documentation Improvements or additions to documentation label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test 5

3 participants