ORC-724: PPD: Date IN single value comparison throws ClassCastException#619
Merged
dongjoon-hyun merged 1 commit intoapache:branch-1.6from Jan 10, 2021
Merged
ORC-724: PPD: Date IN single value comparison throws ClassCastException#619dongjoon-hyun merged 1 commit intoapache:branch-1.6from
dongjoon-hyun merged 1 commit intoapache:branch-1.6from
Conversation
Change-Id: I4445171dcec789f2165d1ae5a82dc911e2ed74a7
dongjoon-hyun
approved these changes
Jan 10, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @pgaref .
Merged to branch-1.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PPD evaluation: Date type Pred baseObject normalization to LocalDate (comparable with ColumnStats)
Why are the changes needed?
Date baseObject normalization is missing leading to ClassCastException when using single Value IN ppd evaluation.
How was this patch tested?
TestRecordReaderImpl.testInDatePredConversion