Skip to content

ORC-724: PPD: Date IN single value comparison throws ClassCastException #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dongjoon-hyun merged 1 commit into from
Jan 10, 2021
Merged

ORC-724: PPD: Date IN single value comparison throws ClassCastException #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,8 @@ private static TruthValue evaluatePredicateMinMax(PredicateLeaf predicate,
// for a single value, look through to see if that value is in the
// set
for (Object arg : predicate.getLiteralList()) {
if (range.compare((Comparable) arg) == Location.MIN) {
predObj = getBaseObjectForComparison(predicate.getType(), (Comparable) arg);
if (range.compare(predObj) == Location.MIN) {
return range.addNull(TruthValue.YES);
}
}
Expand Down
17 changes: 17 additions & 0 deletions java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,6 +1082,23 @@ public void testIn() throws Exception {
evaluateInteger(createIntStats(12L, 18L), pred));
}

@Test
public void testInDatePredConversion() {
List<Object> args = new ArrayList<>();
args.add(toDate(LocalDate.ofEpochDay(15)));
PredicateLeaf pred = createPredicateLeaf
(PredicateLeaf.Operator.IN, PredicateLeaf.Type.DATE,
"x", null, args);
assertEquals(TruthValue.YES_NULL,
evaluateInteger(createDateStats(15, 15), pred));
assertEquals(TruthValue.YES_NO_NULL,
evaluateInteger(createDateStats(10, 30), pred));
assertEquals(TruthValue.NO_NULL,
evaluateInteger(createDateStats(5, 10), pred));
assertEquals(TruthValue.NO_NULL,
evaluateInteger(createDateStats(16, 30), pred));
}

@Test
public void testBetween() {
List<Object> args = new ArrayList<Object>();
Expand Down