Add OSI-Salesforce converter module#118
Merged
Merged
Conversation
khush-bhatia
reviewed
May 1, 2026
Comment on lines
+171
to
+183
| return; | ||
| } | ||
|
|
||
| List<Object> fromColumns = asList(fromColumnsObj); | ||
| List<Object> toColumns = asList(toColumnsObj); | ||
|
|
||
| if (fromColumns.isEmpty() || toColumns.isEmpty()) { | ||
| return; | ||
| } | ||
|
|
||
| if (fromColumns.size() != toColumns.size()) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
All of these should "continue;" instead of return ? We want to skip the bad relationship but still continue handling the other relationships ?
Contributor
Author
There was a problem hiding this comment.
Right, thanks. My intention is to remove those checks in the next PR. They’re all enforced by the schema validation step.
Thank you.
khush-bhatia
approved these changes
May 1, 2026
khush-bhatia
left a comment
khush-bhatia
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks. Left some comments.
jklahr
pushed a commit
to jklahr/jklahr-ossie
that referenced
this pull request
May 18, 2026
Add Ontology & Semantic Interoperability as a top-level current effort with links to discussions apache#22, apache#101, apache#108, apache#68 and PRs apache#124, apache#125. Update existing sections with recently opened discussions, PRs, and converters: metric trees (apache#40), primary key semantics (apache#15, apache#119), reusable datasets (apache#103, apache#109), datatype/is_time reframe (PR apache#113), spatial dimension types (apache#114), default_aggregation (apache#115), positive direction (apache#41), physical metadata (apache#110), and new converter PRs for Salesforce (apache#118), dbt (apache#116), and Databricks (apache#120). Also adds CONTRIBUTING.md (apache#122) and working groups page (apache#123) to Developer Experience, and lists merged converters as existing artifacts. Made-with: Cursor
jklahr
pushed a commit
that referenced
this pull request
May 19, 2026
Add Ontology & Semantic Interoperability as a top-level current effort with links to discussions #22, #101, #108, #68 and PRs #124, #125. Update existing sections with recently opened discussions, PRs, and converters: metric trees (#40), primary key semantics (#15, #119), reusable datasets (#103, #109), datatype/is_time reframe (PR #113), spatial dimension types (#114), default_aggregation (#115), positive direction (#41), physical metadata (#110), and new converter PRs for Salesforce (#118), dbt (#116), and Databricks (#120). Also adds CONTRIBUTING.md (#122) and working groups page (#123) to Developer Experience, and lists merged converters as existing artifacts. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial implementation of the OSI <> Salesforce Semantic Model converters.