fix(Databricks): round-trip display_name on measures (#326) - #356
Merged
jbonofre merged 2 commits intoSep 3, 2026
Conversation
A dimension's display_name maps to the Apache Ossie field `label`, but the Apache Ossie metric shape has no `label`, so a measure's display_name was silently dropped in the MV -> Ossie -> MV round trip. Preserve it in the DATABRICKS custom_extensions stash (the same mechanism as format/window), kept in a separate MEASURE_STASH_KEYS list so the dimension path -- which already maps display_name to `label` -- does not also stash it. The exporter restores it in _convert_metric. Fixes #326. Co-authored-by: Isaac <no-reply@databricks.com>
christianeu-db
marked this pull request as draft
September 3, 2026 20:20
christianeu-db
changed the title
Contributor
Co-authored-by: Isaac <no-reply@databricks.com>
christianeu-db
marked this pull request as ready for review
September 3, 2026 20:32
jbonofre
self-requested a review
September 3, 2026 23:14
jbonofre
approved these changes
Sep 3, 2026
Member
|
Good catch! Thanks! |
Haoranli503
added a commit
to Haoranli503/ossie_databricks
that referenced
this pull request
Sep 4, 2026
…g tables Upstream apache#356 clarified the mapping table (a measure's display_name has no `label` on the Apache Ossie metric shape, so it rides in the DATABRICKS stash). The converter restructure turned the top-level README into a short pointer, so carry that clarification into the mapping tables now in python/README.md and java/README.md. Both converters stash a measure's display_name (Python via apache#356, Java via the measure display_name round-trip commit), so the tables match the behavior. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Databricks converter dropped a measure's
display_nameduring theMV -> Ossie -> MVround trip. A dimension'sdisplay_namemaps to the Apache Ossie fieldlabel, but the Apache Ossie metric shape has nolabel, so a measure'sdisplay_namehad nowhere to go and was silently lost.This preserves it in the
custom_extensions[DATABRICKS]stash (the same mechanism already used forformatandwindow).Related Issues
Fixes #326 for the python converter. #333 will be augmented to include this fix for the Java converter.
Checklist
Specification
N/A - no spec changes
core-spec/and follow the existing structureOntology
N/A - no ontology changes
ontology/are consistent with spec changesConverters
converters/is updated to reflect spec or ontology changesValidation
N/A - no new validation rules
validation/are updated if the spec changedDocumentation
N/A no docs
docs/is updated to reflect any user-facing changesCONTRIBUTING.mdis updated if the contribution process changedExamples
N/A - no new examples
examples/are added or updated for any new spec constructs or converter supportTests
pytest/ CI green)Compliance
AI disclosure
Per the ASF Generative Tooling Guidance, this contribution was prepared with AI assistance. All specification decisions and design choices are mine. I have reviewed and verified every change.