docs: fix incorrect RocketMQService class reference in deploy document - #682
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
The RocketMQ deploy document (EN + CN) pointed users to a class that does not exist:
run.mone.ozhera.operator.service.RocketMQSerivce(misspelled class name + outdatedrun.mone.pre-Apache package prefix). The real class isorg.apache.ozhera.operator.service.RocketMQService.This PR replaces all 4 occurrences (2 in
ozhera-deploy-document.md, 2 inozhera-deploy-document_cn.md) with the correct fully-qualified class name.Ⅱ. Does this pull request fix one issue?
fixes #681
Ⅲ. Why don't you add test cases (unit test/integration test)?
Documentation-only change; nothing to test.
Ⅳ. Describe how to verify it
Grep the deploy docs for
RocketMQSerivce/run.mone.ozhera.operator.serviceand confirm none remain; confirmorg.apache.ozhera.operator.service.RocketMQServicematches the actual class inozhera-operator-service.Ⅴ. Special notes for reviews
The actual class is
org.apache.ozhera.operator.service.RocketMQService(public class RocketMQServicein packageorg.apache.ozhera.operator.service).