Skip to content

HDDS-11968. Only check sibling headings for duplicate titles in markdown lint.#117

Merged
errose28 merged 2 commits into
apache:HDDS-9225-website-v2from
errose28:HDDS-11968-heading-fix
Dec 19, 2024
Merged

HDDS-11968. Only check sibling headings for duplicate titles in markdown lint.#117
errose28 merged 2 commits into
apache:HDDS-9225-website-v2from
errose28:HDDS-11968-heading-fix

Conversation

@errose28
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Markdownlint has a check for duplicate headings, but by default it is global. We only want to enforce this for sibling headings, for example the following it ok:

# Title
## Case 1
### Usage
## Case 2
### Usage

What is the link to the Apache Jira?

HDDS-11968

How was this patch tested?

Markdownlint check passed in this run, which had duplicate non-sibling headings added here

@errose28 errose28 requested a review from adoroszlai December 19, 2024 21:19
@github-actions github-actions Bot added the website-v2 Tasks for the new ozone website targeting the HDDS-9225-website-v2 branch label Dec 19, 2024
@errose28
Copy link
Copy Markdown
Contributor Author

@Eric977 this will fix the error you were seeing in #116

Copy link
Copy Markdown
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @errose28 for the fix.

Comment thread .markdownlint.yaml
@errose28 errose28 merged commit c07d44f into apache:HDDS-9225-website-v2 Dec 19, 2024
@errose28
Copy link
Copy Markdown
Contributor Author

Thanks @adoroszlai for the review

jojochuang pushed a commit to jojochuang/ozone-site that referenced this pull request Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

website-v2 Tasks for the new ozone website targeting the HDDS-9225-website-v2 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants