-
Notifications
You must be signed in to change notification settings - Fork 51
HDDS-14461. [Docs] Core Concepts -> Namespace -> Volume -> Owners #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: HDDS-9225-website-v2
Are you sure you want to change the base?
Conversation
|
I have documented about Volume Owners as per understanding. Please correct or suggest any add-ons needed to be done. |
| </property> | ||
| ``` | ||
| ## 4. Volume Owner vs. Volume Administrator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually i'm not so sure about this.
volume has an admin and an owner field. But the admin field doesn't seem to be used by OM.
I thought it was used to implement S3 multi-tenant, but multi-tenant doesn't use this either. So I really struggle.
@smengcl do you happen to know this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I revisited the code implementation and on that basis, the adminName field in OmVolumeArgs appears to be stored but not functionally used by OM for athorization or access control.
It seems that all authorization checks use ownerName (via getVolumeOwner()), Ozone cluster admins check (via isAdmin()), or ACLs. There's no setVolumeAdmin operation, and adminName is never checked in the authorization path (OzoneNativeAuthorizer, VolumeManager, etc.).
Is it possible that this is a legacy code or reserved for future use. This finding put me in doubt that does adminName has any functional purpose?
Once this is confirmed I will update the document accordingly.
What changes were proposed in this pull request?
https://ozone-site-v2.staged.apache.org/docs/core-concepts/namespace/volumes/owners
This v2 doc page is filled with the content for Volume owners.
Add Volume Owners documentation, covering:
What is the link to the Apache Jira?
https://issues.apache.org/jira/browse/HDDS-14461
How was this patch tested?
Check off which of the following tests were done on this change. If additional testing was done, please elaborate here as well.