HDDS-15996. Flaky TestClientRetryTimeout throws NPE - #10898
Merged
Conversation
adoroszlai
approved these changes
Jul 31, 2026
adoroszlai
left a comment
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @dombizita for the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestClientRetryTimeoutis an ordered, per-class suite where each test retrieves the pipeline of a freshly created key. It did it by casting the first stream entry toRatisBlockOutputStreamand reading the pipeline off itsXceiverClientRatis. This assumes that entry holds a liveXceiverClient, but because earlier tests restart datanodes, the key's client may not be initialized yet, so the access throws an NPE. The NPE also skipskey.close(), causing a secondaryFound 2 leaked objectsfailure.In this change the pipeline is retrieved via
keyOutputStream.getLocationInfoList().get(0).getPipeline()and adds an@AfterEachthat closes the key properly.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15996
How was this patch tested?
Flaky failures without the fix: org.apache.hadoop.ozone.client.rpc.TestClientRetryTimeout#ALL[master]-10x50-java25
All green with the fix: org.apache.hadoop.ozone.client.rpc.TestClientRetryTimeout#ALL[HDDS-15996]-10x50-java25
Generated with Clause Opus 4.8