HDDS-11620. Log SCM finalization completion - #10963
Open
F64116045 wants to merge 2 commits into
Open
Conversation
F64116045
marked this pull request as ready for review
August 7, 2026 03:56
chihsuan
approved these changes
Aug 8, 2026
chihsuan
left a comment
chihsuan
left a comment
Contributor
There was a problem hiding this comment.
Nice improvement! LGTM. 👍
Left one small, non-blocking suggestion.
| // correct order. | ||
| StatusAndMessages status = | ||
| manager.finalizeUpgrade(UUID.randomUUID().toString()); | ||
| LogCapturer logCapturer = |
Contributor
There was a problem hiding this comment.
What do you think about adding a failure-path test for removeFinalizingMark()? Verifying that no completion log is emitted would make the intended behavior explicit.
Contributor
Author
There was a problem hiding this comment.
Thanks @chihsuan for reviewing.
What do you think about adding a failure-path test for removeFinalizingMark()?
I think this makes sense. Added a test for this. Thanks for the suggestion!
sreejasahithi
approved these changes
Aug 10, 2026
sreejasahithi
left a comment
sreejasahithi
left a comment
Contributor
There was a problem hiding this comment.
Thanks @F64116045 for this improvement
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SCM logs when upgrade finalization crosses the
FINALIZATION_STARTEDandMLV_EQUALS_SLVcheckpoints, but it did not log after crossingFINALIZATION_COMPLETE. This made it difficult for operators to determinefrom the SCM log whether finalization completed successfully.
This change logs the
FINALIZATION_COMPLETEcheckpoint after the finalizingmarker is removed successfully. It also extends the SCM finalization test to
verify that the completion message is emitted when finalization advances to
the completed state, but not when SCM is already finalized.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11620
How was this patch tested?
mvn -pl hadoop-hdds/server-scm -am -Dtest=TestScmFinalization \ -Dsurefire.failIfNoSpecifiedTests=false -DskipShade -DskipRecon \ -DskipDocs test mvn -pl hadoop-hdds/server-scm -DskipTests -DskipShade -DskipRecon \ -DskipDocs checkstyle:checkCI: https://github.com/F64116045/ozone/actions/runs/31136447694