HDDS-5192. Intermittent failure in TestOzoneRpcClient due to volume name conflict#2220
Merged
bharatviswa504 merged 2 commits intoapache:masterfrom May 10, 2021
Merged
HDDS-5192. Intermittent failure in TestOzoneRpcClient due to volume name conflict#2220bharatviswa504 merged 2 commits intoapache:masterfrom
bharatviswa504 merged 2 commits intoapache:masterfrom
Conversation
ayushtkn
reviewed
May 8, 2021
| @Test | ||
| public void testListVolume() throws IOException { | ||
| String volBase = "vol-" + RandomStringUtils.randomNumeric(3); | ||
| String volBase = "vol-list-"; |
Member
There was a problem hiding this comment.
Can you update the comment below as well
//Create 10 volume vol-<random>-a-0-<random> to vol-<random>-a-9-<random>
to denote the change here
bharatviswa504
approved these changes
May 10, 2021
Contributor
|
Thank You @adoroszlai for the fix and @ayushtkn for the review. |
Contributor
Author
|
Thanks @ayushtkn and @bharatviswa504 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The name of volume created in
testListBucketsOnEmptyVolumeortestListKeyOnEmptyBucketmight contain the prefix used intestListVolume:which leads to unexpected number of volumes with that prefix:
This fix simply changes to fix volume name for
testListBucketsOnEmptyVolumeand a different fix prefix fortestListVolume, thus avoiding conflict.https://issues.apache.org/jira/browse/HDDS-5192
How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/2521726183