Skip to content

HDDS-5192. Intermittent failure in TestOzoneRpcClient due to volume name conflict #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bharatviswa504 merged 2 commits into from
May 10, 2021
Merged

HDDS-5192. Intermittent failure in TestOzoneRpcClient due to volume name conflict #2220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9246603
HDDS-5192. Intermittent failure in TestOzoneRpcClient due to volume n…
adoroszlai May 6, 2021
3202eb3
Update comment and remove extra -
adoroszlai May 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...ion-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1845,15 +1845,15 @@ public void testKeysRenameFail() throws Exception {

@Test
public void testListVolume() throws IOException {
String volBase = "vol-" + RandomStringUtils.randomNumeric(3);
//Create 10 volume vol-<random>-a-0-<random> to vol-<random>-a-9-<random>
String volBaseNameA = volBase + "-a-";
String volBase = "vol-list-";
Copy link
Member

@ayushtkn ayushtkn May 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the comment below as well
//Create 10 volume vol-<random>-a-0-<random> to vol-<random>-a-9-<random>
to denote the change here

//Create 10 volume vol-list-a-0-<random> to vol-list-a-9-<random>
String volBaseNameA = volBase + "a-";
for(int i = 0; i < 10; i++) {
store.createVolume(
volBaseNameA + i + "-" + RandomStringUtils.randomNumeric(5));
}
//Create 10 volume vol-<random>-b-0-<random> to vol-<random>-b-9-<random>
String volBaseNameB = volBase + "-b-";
//Create 10 volume vol-list-b-0-<random> to vol-list-b-9-<random>
String volBaseNameB = volBase + "b-";
for(int i = 0; i < 10; i++) {
store.createVolume(
volBaseNameB + i + "-" + RandomStringUtils.randomNumeric(5));
Expand Down Expand Up @@ -1964,7 +1964,7 @@ public void testListBucket()
@Test
public void testListBucketsOnEmptyVolume()
throws IOException {
String volume = "vol-" + RandomStringUtils.randomNumeric(5);
String volume = "vol-empty";
store.createVolume(volume);
OzoneVolume vol = store.getVolume(volume);
Iterator<? extends OzoneBucket> buckets = vol.listBuckets("");
Expand Down