HDDS-5400. remove infilght action if node goes into NON-IN-SERVICE#2381
Merged
sodonnel merged 1 commit intoapache:masterfrom Jul 9, 2021
Merged
HDDS-5400. remove infilght action if node goes into NON-IN-SERVICE#2381sodonnel merged 1 commit intoapache:masterfrom
sodonnel merged 1 commit intoapache:masterfrom
Conversation
sodonnel
approved these changes
Jul 9, 2021
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
These changes LGTM.
One comment I had, which is the same as here:
If we are going to drop pending replications from nodes which are no longer IN_SERVICE, then we should ensure the queued replications on the DNs also get dropped. Otherwise the out of service DN may spend a significant time copying containers to itself when it does not have to.
However I believe we are going to address that in #2377 so I am happy to commit this as it is now.
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jul 15, 2021
* master: (90 commits) HDDS-5296. Replication Manager should not sent replicate command to DN which is not IN_SERVICE (apache#2377) HDDS-3432. Enable TestBlockDeletion test cases. (apache#2393) HDDS-5386. Add a NSSummaryTask to write NSSummary info into RDB (apache#2389) HDDS-5384 OM refreshPipeline should not invoke the expensive OmKeyLocationInfoGroup.getLocationList() (apache#2367) HDDS-5426. Remove unused method parameter in XceiverClientGrpc.java (apache#2409) HDDS-5433. Rename hadooprpc proto compilation in pom to refer to proto2. (apache#2407) HDDS-5422. Avoid eager string formatting in preconditions (apache#2396) HDDS-5427. Either re-interrupt this method or rethrow the "InterruptedException" that can be caught here (apache#2404) HDDS-5394. Fix skipped volume check due to disk.check.min.gap. (apache#2373) HDDS-5428. Fix potential BigDecimal precision in StorageUnit.java (apache#2405) HDDS-5421. SCM throws NPE during JMX call. (apache#2398) HDDS-5400. Remove inflight actions in Replication Manager if node switches to not IN_SERVICE (apache#2381) HDDS-5424. Pipeline list command's output should be in local timezone. (apache#2400) HDDS-5416. Intermittent test failure in TestSCMPipelineManager#testPipelineReload (apache#2394) HDDS-5417. Fix json parse stackoverflow for cmd ozone debug container list. (apache#2391) HDDS-5415. Fix TestSCMNodeManager after merge of master at 1d8f972 into upgrade branch (apache#2388) Fix checkstyle after merge. HDDS-5336. Fix datanode capacity related race condition. (apache#2327) HDDS-5333. Remove getRequestType method from OM request classes. HDDS-5109. Track OM prepare intermittent integration test failure. (apache#2288) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
remove infilght action if node goes into NON-IN-SERVICE
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5400
How was this patch tested?
unit test