HDDS-5417. Fix json parse stackoverflow for cmd ozone debug container list.#2391
Merged
adoroszlai merged 1 commit intoapache:masterfrom Jul 8, 2021
Merged
HDDS-5417. Fix json parse stackoverflow for cmd ozone debug container list.#2391adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Hi @adoroszlai , could you please help review this, this bug is after this pr: #2158 |
adoroszlai
approved these changes
Jul 7, 2021
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @guihecheng for the fix. I have verified both the problem and the fix.
(I would prefer adding a test case, but debug smoketest is currently not included in any suites.)
Contributor
Author
|
Thanks @adoroszlai , hmmm, it is nice to have a new suite for debug, we could do it later. |
Contributor
|
Thanks @guihecheng for the fix. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jul 15, 2021
* master: (90 commits) HDDS-5296. Replication Manager should not sent replicate command to DN which is not IN_SERVICE (apache#2377) HDDS-3432. Enable TestBlockDeletion test cases. (apache#2393) HDDS-5386. Add a NSSummaryTask to write NSSummary info into RDB (apache#2389) HDDS-5384 OM refreshPipeline should not invoke the expensive OmKeyLocationInfoGroup.getLocationList() (apache#2367) HDDS-5426. Remove unused method parameter in XceiverClientGrpc.java (apache#2409) HDDS-5433. Rename hadooprpc proto compilation in pom to refer to proto2. (apache#2407) HDDS-5422. Avoid eager string formatting in preconditions (apache#2396) HDDS-5427. Either re-interrupt this method or rethrow the "InterruptedException" that can be caught here (apache#2404) HDDS-5394. Fix skipped volume check due to disk.check.min.gap. (apache#2373) HDDS-5428. Fix potential BigDecimal precision in StorageUnit.java (apache#2405) HDDS-5421. SCM throws NPE during JMX call. (apache#2398) HDDS-5400. Remove inflight actions in Replication Manager if node switches to not IN_SERVICE (apache#2381) HDDS-5424. Pipeline list command's output should be in local timezone. (apache#2400) HDDS-5416. Intermittent test failure in TestSCMPipelineManager#testPipelineReload (apache#2394) HDDS-5417. Fix json parse stackoverflow for cmd ozone debug container list. (apache#2391) HDDS-5415. Fix TestSCMNodeManager after merge of master at 1d8f972 into upgrade branch (apache#2388) Fix checkstyle after merge. HDDS-5336. Fix datanode capacity related race condition. (apache#2327) HDDS-5333. Remove getRequestType method from OM request classes. HDDS-5109. Track OM prepare intermittent integration test failure. (apache#2288) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix json parse stackoverflow for cmd ozone debug container list.
Detailed descriptions in the JIRA.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5417
How was this patch tested?
manual test.