HDDS-5963. Implement ListBlock command.#2829
Closed
ChenSammi wants to merge 2 commits intoapache:masterfrom
Closed
HDDS-5963. Implement ListBlock command.#2829ChenSammi wants to merge 2 commits intoapache:masterfrom
ChenSammi wants to merge 2 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Jan 3, 2022
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @ChenSammi for working on this.
I think we should require container token for ListBlock operation:
ozone/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java
Lines 428 to 440 in e6179c1
...on/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/ContainerCommandResponseBuilders.java
Show resolved
Hide resolved
Comment on lines
+402
to
+417
| private ContainerCommandRequestProto getPutBlockRequest( | ||
| ContainerCommandRequestProto writeChunkRequest) { | ||
| ContainerProtos.BlockData.Builder block = | ||
| ContainerProtos.BlockData.newBuilder() | ||
| .setSize(writeChunkRequest.getWriteChunk().getChunkData().getLen()) | ||
| .setBlockID(writeChunkRequest.getWriteChunk().getBlockID()) | ||
| .addChunks(writeChunkRequest.getWriteChunk().getChunkData()); | ||
| return ContainerCommandRequestProto.newBuilder() | ||
| .setContainerID(writeChunkRequest.getContainerID()) | ||
| .setCmdType(ContainerProtos.Type.PutBlock) | ||
| .setDatanodeUuid(writeChunkRequest.getDatanodeUuid()) | ||
| .setPutBlock(ContainerProtos.PutBlockRequestProto.newBuilder() | ||
| .setBlockData(block.build()) | ||
| .build()) | ||
| .build(); | ||
| } |
Contributor
There was a problem hiding this comment.
Please reuse existing code from ContainerTestHelper:
...-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestHddsDispatcher.java
Show resolved
Hide resolved
...tainer-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
Show resolved
Hide resolved
Contributor
|
/pending |
Contributor
|
because of I can not commit code the sammi's pr, So I take this pr,I take the new one.@adoroszlai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDDS-5963