Skip to content

HDDS-5963. Implement ListBlock command#3212

Merged
guihecheng merged 5 commits intoapache:masterfrom
cchenax:HDDS-5963-1
Apr 2, 2022
Merged

HDDS-5963. Implement ListBlock command#3212
guihecheng merged 5 commits intoapache:masterfrom
cchenax:HDDS-5963-1

Conversation

@cchenax
Copy link
Contributor

@cchenax cchenax commented Mar 18, 2022

@guihecheng
Copy link
Contributor

@cchenax Could you please fix the ut failures, I think they are related to this patch.

@guihecheng
Copy link
Contributor

Hi @adoroszlai , could you please continue reviewing this one?
This is a based on a previous pending issue contributed by Sammi.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cchenax for continuing @ChenSammi's work. Mostly looks good, but few comments from previous PR still apply.

@guihecheng
Copy link
Contributor

Hi all, any updates on this?
I think this interface is important for implementing EC Offline Recovery, we'd better get this done and later we could merge it back to the EC branch.
FYI: https://issues.apache.org/jira/browse/HDDS-6462

@adoroszlai
Copy link
Contributor

Hi all, any updates on this?

I'm waiting for an answer on a code reuse question. Otherwise the patch LGTM.

@guihecheng
Copy link
Contributor

Thanks @ChenSammi @cchenax for the work, thanks @adoroszlai for reviewing.

@guihecheng guihecheng merged commit 2eabcc5 into apache:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments