Skip to content

HDDS-6466. Drop S3 Gateway bucket browser feature #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avijayanhwx merged 2 commits into from
Apr 1, 2022
Merged

HDDS-6466. Drop S3 Gateway bucket browser feature #3241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be755c2
HDDS-6466. Drop S3 Gateway bucket browser feature
adoroszlai Mar 25, 2022
d325078
trigger new CI check
adoroszlai Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions hadoop-hdds/docs/content/interface/S3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,6 @@ By default it uses the path-style addressing. To use virtual host style URLs set
</property>
```

## Bucket browser

Buckets could be browsed from the browser by adding `?browser=true` to the bucket URL.

For example the content of the 'testbucket' could be checked from the browser using the URL http://localhost:9878/testbucket?browser=true


## Implemented REST endpoints

Operations on S3Gateway service:
Expand Down
7 changes: 0 additions & 7 deletions hadoop-hdds/docs/content/interface/S3.zh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,6 @@ Ozone S3 网关既支持虚拟主机风格的 URL 作为桶地址（形如：htt
</property>
```

## 桶浏览器

在桶的 URL 中加上 `?browser=true`，就可以在浏览器中浏览桶。

比如，`testbucket` 桶中的内容可以在浏览器中用 http://localhost:9878/testbucket?browser=true 来查看。


## 已实现的 REST 端点

S3 网关服务的操作：
Expand Down
6 changes: 0 additions & 6 deletions hadoop-hdds/docs/content/start/StartFromDockerHub.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,3 @@ our bucket.
```bash
aws s3 --endpoint http://localhost:9878 ls s3://bucket1/testfile
```

<div class="alert alert-info" role="alert"> You can also check the internal
bucket browser supported by Ozone S3 interface by clicking on the below link.
<br>
</div>
http://localhost:9878/bucket1?browser
5 changes: 0 additions & 5 deletions hadoop-hdds/docs/content/start/StartFromDockerHub.zh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,3 @@ aws s3 --endpoint http://localhost:9878 cp --storage-class REDUCED_REDUNDANCY /
```bash
aws s3 --endpoint http://localhost:9878 ls s3://bucket1/testfile
```

<div class="alert alert-info" role="alert"> 你也可以点击下面的链接，通过 Ozone S3 网关自带的浏览器去查看桶内的文件。
<br>
</div>
http://localhost:9878/bucket1?browser
10 changes: 0 additions & 10 deletions hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ public Response get(
@QueryParam("marker") String marker,
@DefaultValue("1000") @QueryParam("max-keys") int maxKeys,
@QueryParam("prefix") String prefix,
@QueryParam("browser") String browser,
@QueryParam("continuation-token") String continueToken,
@QueryParam("start-after") String startAfter,
@QueryParam("uploads") String uploads,
Expand All @@ -108,15 +107,6 @@ public Response get(
return Response.ok(result, MediaType.APPLICATION_XML_TYPE).build();
}

if (browser != null) {
InputStream browserPage = getClass()
.getResourceAsStream("/browser.html");
return Response.ok(browserPage,
MediaType.TEXT_HTML_TYPE)
.build();

}

if (uploads != null) {
return listMultipartUploads(bucketName, prefix);
}
Expand Down
Loading