HDDS-8320. Fix ranger jackson version conflict #4504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
reviewed
Mar 30, 2023
Contributor
|
Looks like the jar file list needs updating now that we are not excluding the ranger transitive dependency |
adoroszlai
requested changes
Mar 31, 2023
Comment on lines
+162
to
+163
| <jackson1.version>1.9.13</jackson1.version> | ||
| <jackson-jaxr.version>1.9.13</jackson-jaxr.version> |
Contributor
There was a problem hiding this comment.
Please add a separate version property for jackson-mapper-asl. It tends to have a patch version.
On the other hand, I don't think we need a separate version property for jackson-jaxrs, it can use the generic jackson1-version.
Contributor
Author
There was a problem hiding this comment.
Both jackson-mapper-asl & jackson-core-asl have the same patch version. jackson-jaxrs doesn't seem to have a patched version.
adoroszlai
approved these changes
Mar 31, 2023
smengcl
reviewed
Apr 4, 2023
| <artifactId>jersey-client</artifactId> | ||
| </dependency> | ||
|
|
||
| <!-- Overrider ranger-intg jackson version --> |
Contributor
There was a problem hiding this comment.
Uh oh I noticed the typo in the comment too late. Guess we can fix it next time.
smengcl
reviewed
Apr 13, 2023
|
|
||
| <!-- jackson versions --> | ||
| <jackson1.version>1.9.13</jackson1.version> | ||
| <jackson-jaxr.version>1.9.13</jackson-jaxr.version> |
Contributor
There was a problem hiding this comment.
Unfortunately there is also a typo in the tag name. Missing an s at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ranger depends on jackson version 1.9.13. Please check #4497
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8320
How was this patch tested?
Ozone Internal tests