-
Notifications
You must be signed in to change notification settings - Fork 594
HDDS-8320. Remove exclusion of jackson from ranger-intg #4497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: Ibf720025c5eaf0bec781c59b9b0cedcbb0289fb6
This reverts commit 25a911c.
…vergence enforcer check. Change-Id: Ie67563da617f3a0dc6e4cb3659cc8718838727ae
|
Marking this as draft as @swamirishi is still tuning the Maven POM. Will add LICENSE later. |
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @smengcl for the patch and sorry for the trouble caused by the exclusion.
| <dependency> | ||
| <groupId>org.codehaus.jackson</groupId> | ||
| <artifactId>jackson-core-asl</artifactId> | ||
| <version>${jackson1.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what Ranger brings without the exclusion:
[INFO] | +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:compile
[INFO] | | +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile
[INFO] | | \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile
If we want to add explicit dependency, I think we should add jackson-jaxrs, not jackson-core-asl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adoroszlai for looking at this. @swamirishi has added jaxrs in #4504 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jaxrs doesn't have the internal build version. Ozone depends on specific internal build jackson-core-asl & jackson-mapper-asl. In order to fix this we need to exclude jackson-core-asl & jackson-mapper-asl from jackson-jaxrs & include the specified version to fix the conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check #4504 for the fix.
|
Closing this one in favor of #4504 . |
What changes were proposed in this pull request?
It turns out excluding jackson in HDDS-7924 might have broken actual ranger-intg client usage:
Unfortunately our acceptance tests didn't cover the actual Ranger client testing because the infra is not there yet. iirc @djordje-mijatovic is trying to improve the docker dev env to spin up actual Ranger, at which point we could write new acceptance tests that uses ranger-intg client to run against actual Ranger Admin Server so that we can avoid such issues in the future.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8320
How was this patch tested?