Skip to content

HDDS-9161. Recon Pipelines datanode columns search does not work#5213

Merged
dombizita merged 7 commits intoapache:masterfrom
smitajoshi12:HDDS-9161
Sep 13, 2023
Merged

HDDS-9161. Recon Pipelines datanode columns search does not work#5213
dombizita merged 7 commits intoapache:masterfrom
smitajoshi12:HDDS-9161

Conversation

@smitajoshi12
Copy link
Contributor

@smitajoshi12 smitajoshi12 commented Aug 23, 2023

What changes were proposed in this pull request?

There are values present in the column, but the search does not filter them out. so Now search Functionality is working on Array and Objects

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9161

How was this patch tested?

Manually

pieplines.webm

From UID Search
image

image

@smitajoshi12 smitajoshi12 changed the title HDDS-9161. Recon Pipelines datanode columns search does not work. HDDS-9161. Recon Pipelines datanode columns search does not work Aug 23, 2023
Copy link
Contributor

@devabhishekpal devabhishekpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smitajoshi12 LGTM +1

Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this @smitajoshi12! I tested your patch in a docker cluster locally and when I filtered for a datanode (both in case of hostname or UUID) that is not the first datanode in the list at the RATIS (THREE) pipeline it only showed the RATIS (ONE) pipeline.
please see the following screeshots:

  1. before filtering
before_filter
  1. after filtering for ozone_datanode_3.ozone_default
after_filter

@smitajoshi12
Copy link
Contributor Author

thanks for working on this @smitajoshi12! I tested your patch in a docker cluster locally and when I filtered for a datanode (both in case of hostname or UUID) that is not the first datanode in the list at the RATIS (THREE) pipeline it only showed the RATIS (ONE) pipeline. please see the following screeshots:

  1. before filtering
before_filter 2. after filtering for `ozone_datanode_3.ozone_default` after_filter

@dombizita
I have uploaded video of Recent Changes which covers bug you found.
Thanks Zita

@dombizita
Copy link
Contributor

please review it again, if you have time @devabhishekpal

devabhishekpal

This comment was marked as outdated.

Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for addressing my comments, there is one indentation fix I commented below, beside this it looks good to me!

Copy link
Contributor

@devabhishekpal devabhishekpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smitajoshi12 Thanks for making the changes, and thanks @dombizita for the reviews as well.
Looks good to me now, +1

@dombizita dombizita merged commit 2652ec4 into apache:master Sep 13, 2023
@dombizita
Copy link
Contributor

thanks for working on this @smitajoshi12! thanks for the review @devabhishekpal!

errose28 added a commit to errose28/ozone that referenced this pull request Sep 14, 2023
* master: (55 commits)
  HDDS-9236. Fix snapdiff output for key modification (apache#5258)
  HDDS-8013. Freon S3 bucket creation test should use unique prefix (apache#5282)
  HDDS-9228. Poor S3G read performance (apache#5274)
  HDDS-8941. Disable flaky TestContainerBalancerTask#testDelayedStart
  HDDS-1159. Remove flaky tag from TestContainerStateManagerIntegration (apache#5291)
  HDDS-6077. Remove flaky tag from TestAddRemoveOzoneManager (apache#5290)
  HDDS-6610. Remove support for recursive volume list/delete using ozone fs command (apache#5264)
  HDDS-7752. GetS3SecretRequest API should not return secret if secret of user already exists (apache#4538)
  HDDS-9173. Invalidate snapshot cache once snapshot gets purged (apache#5248)
  HDDS-8920. Ozone is supporting unicode volume and bucket names, unintentionally (apache#5276)
  HDDS-9275. LegacyReplicationManager: Delete excess unhealthy with force=true (apache#5286)
  HDDS-9264. Execute EC acceptance test in secure environment (apache#5279)
  HDDS-9161. Recon Pipelines datanode columns search does not work (apache#5213)
  HDDS-9107. Reduce the granularity of Container locks for BlockDeletingService (apache#5149)
  HDDS-9270. Create a script to list all acceptance test splits (apache#5281)
  HDDS-9220. Let ContainerBalancerConfiguration#toString print more info (apache#5228)
  HDDS-9208. Add queue limit in ReplicationServer. (apache#5216)
  HDDS-9268. [Snapshot] Update list of snapshot apis to include lsDiff details in docs. (apache#5278)
  HDDS-9234. OM should shutdown immediately if certificate durations are invalid (apache#5243)
  HDDS-9136. Throw exception when rename fails during moveToTrash. (apache#5253)
  ...
@smitajoshi12 smitajoshi12 deleted the HDDS-9161 branch September 21, 2023 09:00
swamirishi pushed a commit to swamirishi/ozone that referenced this pull request Jun 10, 2024
…ot work (apache#5213)

(cherry picked from commit 2652ec4)
Change-Id: Ic33b7455b5736a46a6e619364f17c9756f0298b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments