Skip to content

HDDS-9220. Let ContainerBalancerConfiguration#toString print more info#5228

Merged
ChenSammi merged 4 commits intoapache:masterfrom
YuanbenWang:HDDS-9220
Sep 13, 2023
Merged

HDDS-9220. Let ContainerBalancerConfiguration#toString print more info#5228
ChenSammi merged 4 commits intoapache:masterfrom
YuanbenWang:HDDS-9220

Conversation

@YuanbenWang
Copy link
Contributor

What changes were proposed in this pull request?

This pr aims to let ContainerBalancerConfiguration#toString print more information when called.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9220

How was this patch tested?

From:
Before

To:
After

Copy link
Contributor

@siddhantsangwan siddhantsangwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuanbenWang thanks for working on this. I just have one comment below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Time Limit for Container Replication's Move",
"Time Limit for Single Container's Replication",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review~! I have changed it.

Copy link
Contributor

@Xushaohong Xushaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving more direct config details. It looks good to me. thx @YuanbenWang

@YuanbenWang
Copy link
Contributor Author

Giving more direct config details. It looks good to me. thx @YuanbenWang

Thanks for the review~!

Copy link
Contributor

@dineshchitlangia dineshchitlangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 pending CI

@YuanbenWang
Copy link
Contributor Author

+1 pending CI

Thanks for the review~! I have fix the checkstyle.

@YuanbenWang
Copy link
Contributor Author

@dineshchitlangia CI got 503 error code, so could you help to retrigger it ? Thx.

@YuanbenWang
Copy link
Contributor Author

In my own CI, all test are success.
HDDS-9220

@siddhantsangwan
Copy link
Contributor

I've triggered a CI run.

@YuanbenWang
Copy link
Contributor Author

YuanbenWang commented Sep 8, 2023

I've triggered a CI run.

All the test are success. Would you please help merge this pr?

@ChenSammi ChenSammi merged commit db23111 into apache:master Sep 13, 2023
@ChenSammi
Copy link
Contributor

Thanks @YuanbenWang for the contribution, @Xushaohong and @dineshchitlangia, @siddhantsangwan for the code review.

@YuanbenWang YuanbenWang deleted the HDDS-9220 branch September 13, 2023 08:07
@YuanbenWang
Copy link
Contributor Author

@siddhantsangwan @ChenSammi @dineshchitlangia @Xushaohong Thank you for your assistance in reviewing the code!

errose28 added a commit to errose28/ozone that referenced this pull request Sep 14, 2023
* master: (55 commits)
  HDDS-9236. Fix snapdiff output for key modification (apache#5258)
  HDDS-8013. Freon S3 bucket creation test should use unique prefix (apache#5282)
  HDDS-9228. Poor S3G read performance (apache#5274)
  HDDS-8941. Disable flaky TestContainerBalancerTask#testDelayedStart
  HDDS-1159. Remove flaky tag from TestContainerStateManagerIntegration (apache#5291)
  HDDS-6077. Remove flaky tag from TestAddRemoveOzoneManager (apache#5290)
  HDDS-6610. Remove support for recursive volume list/delete using ozone fs command (apache#5264)
  HDDS-7752. GetS3SecretRequest API should not return secret if secret of user already exists (apache#4538)
  HDDS-9173. Invalidate snapshot cache once snapshot gets purged (apache#5248)
  HDDS-8920. Ozone is supporting unicode volume and bucket names, unintentionally (apache#5276)
  HDDS-9275. LegacyReplicationManager: Delete excess unhealthy with force=true (apache#5286)
  HDDS-9264. Execute EC acceptance test in secure environment (apache#5279)
  HDDS-9161. Recon Pipelines datanode columns search does not work (apache#5213)
  HDDS-9107. Reduce the granularity of Container locks for BlockDeletingService (apache#5149)
  HDDS-9270. Create a script to list all acceptance test splits (apache#5281)
  HDDS-9220. Let ContainerBalancerConfiguration#toString print more info (apache#5228)
  HDDS-9208. Add queue limit in ReplicationServer. (apache#5216)
  HDDS-9268. [Snapshot] Update list of snapshot apis to include lsDiff details in docs. (apache#5278)
  HDDS-9234. OM should shutdown immediately if certificate durations are invalid (apache#5243)
  HDDS-9136. Throw exception when rename fails during moveToTrash. (apache#5253)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments