HDDS-14000. Require existing build for acceptance/kubernetes check#9377
Merged
Conversation
Contributor
Contributor
Author
|
Thanks @jojochuang for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
acceptance and kubernetes checks use Ozone binaries for tests. If those are not found, they perform a full build on their own. The PR proposes to remove this fallback build.
In CI binaries are produced by the build check. If acceptance/kubernetes are unable to find those, we can simply retry (for transient errors) or need to investigate anyway (for other unexpected problems). The fallback build just increases the time until eventual failure.
For local runs, I think it's better to give developers a chance to build Ozone with their own preferences (e.g. skip Recon, skip shading).
https://issues.apache.org/jira/browse/HDDS-14000
How was this patch tested?
https://github.com/adoroszlai/ozone/actions/runs/19696847361