fix(types): make RowKind short string parsing case-insensitive#15
fix(types): make RowKind short string parsing case-insensitive#15slfan1989 wants to merge 1 commit into
Conversation
|
@zjw1111 @leaves12138 Could we accept this small change? Thank you very much! |
|
Thank you for the contribution. This fix looks correct and addresses the case-sensitivity issue. We have a utility function, |
@lxy-9602 Thank you for the feedback. That sounds good to me. I’m happy to wait until Thanks again! |
Purpose
Linked issue: close #14
Make
RowKind::FromShortStringconsistent with Java Paimon'sRowKind.fromShortStringbehavior.Java Paimon normalizes the input to uppercase before matching, so lowercase short strings such as
+i,-u,+u, and-dare accepted. This PR updates paimon-cpp to accept the same lowercase variants.Tests
Added unit test coverage for lowercase RowKind short strings:
+imaps toINSERT-umaps toUPDATE_BEFORE+umaps toUPDATE_AFTER-dmaps toDELETEAPI and Format
No.
This change does not affect public API headers under include/, storage format, or protocol.
Documentation
No.
This is a compatibility bug fix and does not introduce a new feature.
Generative AI tooling