Skip to content

fix(types): make RowKind short string parsing case-insensitive #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slfan1989 wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −4
Open

fix(types): make RowKind short string parsing case-insensitive #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/paimon/common/types/row_kind.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,13 @@ class RowKind {
///
/// @see #shortString() for mapping of string and `RowKind`.
static Result<const RowKind*> FromShortString(const std::string& value) {
if (value == "+I") {
if (value == "+I" || value == "+i") {
return Insert();
} else if (value == "-U") {
} else if (value == "-U" || value == "-u") {
return UpdateBefore();
} else if (value == "+U") {
} else if (value == "+U" || value == "+u") {
return UpdateAfter();
} else if (value == "-D") {
} else if (value == "-D" || value == "-d") {
return Delete();
} else {
return Status::Invalid(fmt::format("Unsupported short string {} for row kind.", value));
Expand Down
12 changes: 12 additions & 0 deletions src/paimon/common/types/row_kind_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,16 @@ TEST(RowKindTest, TestSimple) {
ASSERT_FALSE(*insert == *delete_kind);
}

TEST(RowKindTest, TestFromShortStringIgnoresCase) {
ASSERT_OK_AND_ASSIGN(const RowKind* insert, RowKind::FromShortString("+i"));
ASSERT_OK_AND_ASSIGN(const RowKind* update_before, RowKind::FromShortString("-u"));
ASSERT_OK_AND_ASSIGN(const RowKind* update_after, RowKind::FromShortString("+u"));
ASSERT_OK_AND_ASSIGN(const RowKind* delete_kind, RowKind::FromShortString("-d"));

ASSERT_EQ(insert, RowKind::Insert());
ASSERT_EQ(update_before, RowKind::UpdateBefore());
ASSERT_EQ(update_after, RowKind::UpdateAfter());
ASSERT_EQ(delete_kind, RowKind::Delete());
}

} // namespace paimon::test