fix: make release version parsing portable#157
Closed
zjw1111 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Superseded by #156. The portable release-version parsing commit has been moved to that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: N/A
Make CMake project-version parsing portable across GNU/Linux and macOS/BSD environments. The previous basic regular expressions used the GNU sed extension
\+, so both release scripts returned an empty version with BSD sed. Use POSIX awk extended regular expressions instead.PR #156 fixes an unrelated cmake-format failure already present on the current main branch. Until that PR is merged, an all-files pre-commit run also rewrites examples/CMakeLists.txt; the hooks for the files changed here pass.
Tests
sed --posix0.2.3from both the working tree and Git content with the new awk expressionbash -n scripts/releasing/create_source_release.sh scripts/releasing/verify_release_candidate.shscripts/releasing/create_source_release.sh --version 0.2.3 --git-ref HEAD --output-dir <temp-dir>scripts/releasing/verify_release_candidate.sh --allow-unsigned --skip-rat --skip-build <artifact>pre-commit run --files scripts/releasing/create_source_release.sh scripts/releasing/verify_release_candidate.shgit diff --checkAPI and Format
No API, storage format, or protocol changes.
Documentation
No documentation changes.
Generative AI tooling
Generated-by: Codex (GPT-5)