Skip to content

fix(commit): allow disabled manifest delete stats option #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteNicholas merged 1 commit into from
Aug 6, 2026
+13 −1
Merged

fix(commit): allow disabled manifest delete stats option #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/paimon/core/operation/file_store_commit_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
#include "paimon/common/utils/binary_row_partition_computer.h"
#include "paimon/common/utils/date_time_utils.h"
#include "paimon/common/utils/fields_comparator.h"
#include "paimon/common/utils/options_utils.h"
#include "paimon/common/utils/path_util.h"
#include "paimon/common/utils/scope_guard.h"
#include "paimon/core/catalog/catalog_snapshot_commit.h"
Expand Down Expand Up @@ -116,7 +117,12 @@ Status FileStoreCommitImpl::ValidateCommitOptions(const CoreOptions& options) {
unsupported_options.emplace_back(kCommitStrictModeLastSafeSnapshot);
}
if (raw_options.find(kManifestDeleteFileDropStats) != raw_options.end()) {
unsupported_options.emplace_back(kManifestDeleteFileDropStats);
PAIMON_ASSIGN_OR_RAISE(
bool manifest_delete_file_drop_stats,
OptionsUtils::GetValueFromMap<bool>(raw_options, kManifestDeleteFileDropStats));
if (manifest_delete_file_drop_stats) {
unsupported_options.emplace_back(kManifestDeleteFileDropStats);
}
}
if (raw_options.find(kSequenceSnapshotOrdering) != raw_options.end()) {
unsupported_options.emplace_back(kSequenceSnapshotOrdering);
Expand Down
6 changes: 6 additions & 0 deletions src/paimon/core/operation/file_store_commit_impl_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2550,6 +2550,12 @@ TEST_F(FileStoreCommitImplTest, ValidateCommitOptionsRejectsUnsupportedOptions)
ASSERT_OK(FileStoreCommitImpl::ValidateCommitOptions(ok_options));
}

TEST_F(FileStoreCommitImplTest, ValidateCommitOptionsAllowsDisabledManifestDeleteFileDropStats) {
ASSERT_OK_AND_ASSIGN(CoreOptions options,
CoreOptions::FromMap({{"manifest.delete-file-drop-stats", "false"}}));
ASSERT_OK(FileStoreCommitImpl::ValidateCommitOptions(options));
}

TEST_F(FileStoreCommitImplTest, DropPartitionWithEmptyPartitionsFails) {
CommitContextBuilder context_builder(table_path_, "commit_user_1");
ASSERT_OK_AND_ASSIGN(std::unique_ptr<CommitContext> commit_context,
Expand Down
Loading