fix(datafusion): guard CoW MERGE partition pruning#475
Open
JaydenHD wants to merge 1 commit into
Open
Conversation
JaydenHD
force-pushed
the
fix-cow-merge-pruning
branch
from
6325422 to
70b0398
Compare
JaydenHD
force-pushed
the
fix-cow-merge-pruning
branch
from
70b0398 to
b6ae9ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ONcondition directly equates every target partition column with the same source columnONclause does not join on that partition columnCloses #474.
Tests
cargo fmt --checkcargo check -p paimon-datafusion --libcargo test -p paimon-datafusion --lib merge_into::tests::test_source_partition_pruning -- --nocaptureNote:
cargo test -p paimon-datafusion --test append_merge_into test_partitioned_update_and_insert -- --nocapturecurrently panics in this Windows environment inside OpenDAL fs listing (StripPrefixError(())), and the same happens for the new append_merge_into regression test. The new pure unit tests cover the pruning guard locally; the integration regression is included for CI/Linux coverage.