Support dedicated vector storage writes#484
Merged
Merged
Conversation
c0773ed to
17efdc8
Compare
leaves12138
approved these changes
Jul 8, 2026
leaves12138
left a comment
There was a problem hiding this comment.
Looks good to me. I reviewed the updated dedicated vector storage writer changes, fixed the Clippy large-enum-variant issue by boxing the dedicated writer variant, and verified the relevant paths locally.
Validated locally:
cargo fmt --checkcargo clippy -p paimon --all-targets --features vortex -- -D warningscargo test -p paimon --lib vectorcargo test -p paimon --features vortex --lib test_vector_write_uses_dedicated_vortex_file
The full workspace Clippy check could not be reproduced locally because this environment lacks a dynamically embeddable Python for PyO3, but the CI blocker was isolated to the paimon crate and is fixed in the latest commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add writer support for dedicated vector storage so tables configured with
vector.file.formatwrite vector columns into*.vector.<format>files instead of ordinary data files. This aligns append and data-evolution partial writes with the existing reader support for.vector.*files.Changes
vector.file.formatandvector.target-file-sizeoption accessors..vector.parquet,.vector.vortex, option defaults, schema validation, and blob regression.Testing
cargo test -p paimon --lib vectorcargo test -p paimon --lib blob_writecargo test -p paimon --features vortex --lib test_vector_write_uses_dedicated_vortex_filegit diff --checkNotes
No migration is required. Existing inline VECTOR writes are unchanged when
vector.file.formatis not configured.