fix(spec): normalize file-format options to lowercase - #663
Merged
Conversation
Java routes every file-format option through `CoreOptions.normalizeFileFormat`, which lowercases the value. Rust returned it verbatim, and `DataFileWriter` interpolates it straight into the file name, so `'file.format' = 'PARQUET'` wrote `data-<uuid>-0.PARQUET` where Java writes `.parquet`. Reads still worked because the format dispatch lowercases the path, so the effect was inconsistent file naming rather than a hard failure. Trim and lowercase in `file_format`, `changelog_file_format` and `vector_file_format`, and treat a blank value as unset so it falls back to the default instead of yielding an empty extension. Two consumers that re-did `.trim().to_ascii_lowercase()` themselves now rely on the accessor.
jackylee-ch
force-pushed
the
fix/normalize-file-format
branch
from
August 4, 2026 02:12
1c641ed to
eefcbf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java routes every file-format option through
CoreOptions.normalizeFileFormat,which lowercases the value. Rust returned it verbatim, and
DataFileWriterinterpolates it straight into the file name — so
'file.format' = 'PARQUET'wrotedata-<uuid>-0.PARQUETwhere Java writes.parquet. Reads still worked (the formatdispatch lowercases the path), so the effect was inconsistent file naming rather
than a hard failure.
Fix: trim and lowercase in
file_format,changelog_file_formatandvector_file_format, and treat a blank value as unset so it falls back to thedefault instead of yielding an empty extension. Two consumers that re-did
.trim().to_ascii_lowercase()themselves now rely on the accessor.