Skip to content

fix(python): render field types as SQL strings, not Rust Debug #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackylee-ch wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(python): render field types as SQL strings, not Rust Debug #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18dd26b
fix(python): render field types as SQL strings, not Rust Debug
jackylee-ch Sep 2, 2026
c5cb748
fix(spec): quote ROW field names with Java identifier syntax
jackylee-ch Sep 4, 2026
3698f63
fix(spec): align escape_identifier with Java backtick syntax
jackylee-ch Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bindings/python/src/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ impl PyDataField {
}

fn field_type(&self) -> String {
// TODO(#284 follow-up): mirror Java DataType.asSQLString() once
// a Display impl is added to paimon::spec::DataType.
format!("{:?}", self.inner.data_type())
// Java `DataField.type().asSQLString()`, which is what
// `Display for DataType` renders.
self.inner.data_type().to_string()
}

fn is_nullable(&self) -> bool {
Expand Down
13 changes: 10 additions & 3 deletions crates/paimon/src/spec/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,8 +1119,10 @@ impl DataField {
}
}

/// Quote an identifier the way Java `EncodingUtils.escapeIdentifier` does: wrap it
/// in backticks and double any backtick it contains.
pub fn escape_identifier(identifier: &str) -> String {
identifier.replace('"', "\"\"")
format!("`{}`", identifier.replace('`', "``"))
}

pub fn escape_single_quotes(text: &str) -> String {
Expand Down Expand Up @@ -2386,8 +2388,13 @@ mod tests {

#[test]
fn test_escape_identifier() {
let escaped_identifier = escape_identifier("\"identifier\"");
assert_eq!(escaped_identifier, "\"\"identifier\"\"");
// Java doubles backticks and wraps in backticks; a double quote is not
// special (`EncodingUtils.escapeIdentifier`).
assert_eq!(escape_identifier("id"), "`id`");
assert_eq!(escape_identifier("a`b"), "`a``b`");
assert_eq!(escape_identifier("\"identifier\""), "`\"identifier\"`");
assert_eq!(escape_identifier("two words"), "`two words`");
assert_eq!(escape_identifier(""), "``");
}

#[test]
Expand Down
Loading
Loading