[python] Pass Mosaic options to writer#8400
Merged
Merged
Conversation
Python Mosaic writes called mosaic.write_table without propagating table options, so configured bucket count, stats columns, block size, and zstd level were ignored on Python write paths. Build Mosaic WriterOptions from CoreOptions and pass them through Python data writers and FileIO implementations. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Python Mosaic writes built data files with
mosaic.write_table(data, stream)and did not pass table options into MosaicWriterOptions. As a result, Python tables usingfile.format=mosaicignored configuredmosaic.num-buckets,mosaic.stats-columns,file.block-size, andfile.compression.zstd-level.This PR maps the relevant table options into Mosaic writer options and passes them through Python data writers and FileIO implementations.
Tests
python -m pytest pypaimon/tests/mosaic_writer_options_test.py -qpython -m pytest pypaimon/tests/test_format_mosaic_reader_writer.py pypaimon/tests/mosaic_writer_options_test.py -q