[core][python] Improve data evolution row-id conflict diagnostics#8491
Conversation
7806961 to
9d0e3cc
Compare
|
Thanks for the clarification. If the goal of this PR is only to improve the diagnostics, I think this direction is reasonable. Before merging, could we please tighten two small points so Java and PyPaimon stay aligned and the intended non-conflict cases are covered?
With those covered, this looks good to merge as a diagnostics-only improvement. This PR should not be interpreted as allowing blob/vector compaction to span multiple normal data-file row-id ranges. |
9d0e3cc to
4f4c689
Compare
|
Addressed the review comments in the latest push:\n\n- PyPaimon |
leaves12138
left a comment
There was a problem hiding this comment.
LGTM. Reviewed the row-id conflict diagnostics changes for Java and Python, and verified with targeted ConflictDetection tests.
Summary
This PR improves Data Evolution row-id range conflict detection so normal data files and dedicated storage files are checked separately. It prevents adjacent normal data files from being reported without the blob/vector file that actually connects their row-id ranges.
Changes
Testing
mvn -pl paimon-core -Pfast-build -Dtest=ConflictDetectionTest surefire:testPYTHONPATH=paimon-python python -m pytest paimon-python/pypaimon/tests/write/conflict_detection_test.py -qNotes
The Java test was run with the surefire goal after locally compiling the touched classes, because the full local
paimon-coretest lifecycle is currently blocked by unrelated compile errors in this checkout.