Skip to content

[docs] Fix stale sink.writer-coordinator.cache-memory default value#8510

Merged
JingsongLi merged 1 commit into
apache:masterfrom
thswlsqls:docs/fix-writer-coordinator-cache-memory-default
Jul 9, 2026
Merged

[docs] Fix stale sink.writer-coordinator.cache-memory default value#8510
JingsongLi merged 1 commit into
apache:masterfrom
thswlsqls:docs/fix-writer-coordinator-cache-memory-default

Conversation

@thswlsqls

Copy link
Copy Markdown
Contributor

Purpose

  • The "Write Initialize" section states the default of sink.writer-coordinator.cache-memory as 1GB, but the source default is 2GB.
  • FlinkConnectorOptions.SINK_WRITER_COORDINATOR_CACHE_MEMORY is defined as defaultValue(MemorySize.ofMebiBytes(2048)) (= 2GB).
  • Commit abb779813 raised the default from ofMebiBytes(1024) to ofMebiBytes(2048), but this hand-written prose was never updated. Fixes the doc-vs-code drift so users tune Job Manager memory with the correct value.

Tests

  • Documentation-only wording fix, no behavior change — no test added.
  • Corrected value verified against FlinkConnectorOptions.java (ofMebiBytes(2048) = 2GB). Docs-only change, no module build.

@JingsongLi

JingsongLi commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Can you just merge all doc related PRs to a single?

@JingsongLi JingsongLi merged commit f2ae9f6 into apache:master Jul 9, 2026
2 checks passed
@thswlsqls

Copy link
Copy Markdown
Contributor Author

@JingsongLi Makes sense — thanks for the guidance. I'll batch documentation fixes into a single PR going forward instead of opening one per change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants