[api] Avoid overflow in composite type default size#8517
Merged
JingsongLi merged 1 commit intoJul 9, 2026
Conversation
RowType/MapType/MultisetType defaultSize() summed int sizes without overflow guard, wrapping to negative; use MathUtils.addSafely to saturate at Integer.MAX_VALUE, matching VectorType (PR apache#8360). Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #8513
RowType,MapTypeandMultisetTypedefaultSize()summed child int sizes without an overflow guard, wrapping to a negative value when a child size nearsInteger.MAX_VALUE.Integer.MAX_VALUEvia the existingMathUtils.addSafely(int,int)(no new API or dependency), matchingVectorType.defaultSize()fixed in PR [api] Avoid overflow in VectorType default size #8360, which left these sibling composite types unguarded.Tests
DefaultSizeOverflowTestcovering normal sums (ROW/MAP/MULTISET) and overflow saturation for a largeVECTORchild in each composite type.mvn -pl paimon-api -DfailIfNoTests=false clean install— passed.