Skip to content

[python] Fix update_by_row_id commit cleanup semantics#8522

Merged
JingsongLi merged 2 commits into
apache:masterfrom
QuakeWang:update-rowid-commit-boundaries
Jul 10, 2026
Merged

[python] Fix update_by_row_id commit cleanup semantics#8522
JingsongLi merged 2 commits into
apache:masterfrom
QuakeWang:update-rowid-commit-boundaries

Conversation

@QuakeWang

Copy link
Copy Markdown
Member

Purpose

Fix update_by_row_id commit lifecycle handling so failures around commit cleanup follow the same transaction boundary as merge_into:

  • abort pending commit messages only when failure happens before commit starts
  • do not abort once commit has started
  • log commit/abort close failures as warnings so they do not override a successful commit or mask the original commit failure

This keeps the change scoped to update_by_row_id commit/abort/close semantics and adds regression coverage for the failure boundaries.

Tests

  • python -m pytest pypaimon/tests/ray_update_by_row_id_test.py -q
  • git diff --check

@JingsongLi

Copy link
Copy Markdown
Contributor

+1

@JingsongLi JingsongLi merged commit 51fd07c into apache:master Jul 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants