[benchmark] Fix stale throughput and duration docs in cluster README - #8752
Closed
thswlsqls wants to merge 1 commit into
Closed
[benchmark] Fix stale throughput and duration docs in cluster README#8752thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Generated-by: Claude Code
Contributor
|
-1 It's pointless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Two README lines still describe the behavior from before 8815608 (#274), although that commit updated the neighbouring lines.
Throughput/Coreisrps / cpu, whererpsreads Flink'snumRecordsOutPerSecond(JobBenchmarkMetric#getRpsPerCore) — rows, not bytes. The README also names the columnThroughput/Cores, whileBenchmarkprintsThroughput/Core.row-numrows fromqueries.yaml, not after 30 minutes: that commit removedbenchmark.metric.monitor.durationand left a sentence contradicting "Each SQL script will stop only after it produces enough number of rows" below it.No linked issue: docs wording fix, no open issue on this topic.
Tests
mvn spotless:check -pl paimon-benchmark/paimon-cluster-benchmarkpasses.