[benchmark] Close seekable input streams in bitmap benchmarks - #8756
Closed
thswlsqls wants to merge 1 commit into
Closed
[benchmark] Close seekable input streams in bitmap benchmarks#8756thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Generated-by: Claude Code
Contributor
|
Don't make these pointless changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #8755
LocalFileIO.LocalSeekableInputStreamof fivebenchmark/bitmapcases in try-with-resources:RoaringBitmapBenchmark.testDeserialize()(second case),BitmapIndexBenchmark.query(), andRangeBitmapIndexBenchmark.queryBsi()/queryBitmap()/queryRangeBitmap().RoaringBitmapBenchmark.testDeserialize()already use try-with-resources — the second case was the only one missing it.LocalFileIO.LocalSeekableInputStream.close()closes the underlyingFileInputStream, so without it release is left to the GC.catch (FileNotFoundException)tocatch (IOException)in the four query methods, required now thatclose()is on the path. The measured logic is unchanged.Tests
*Testclass (all 17 files are benchmarks) and the change only affects cleanup.mvn spotless:checkandmvn -DskipTests clean test-compileonpaimon-benchmark/paimon-micro-benchmarkspassed.@Testmethods here run real benchmarks, so they were not run locally.