[codegen] Fix generated map comparator comparing values by key type - #8763
Merged
JingsongLi merged 1 commit intoJul 21, 2026
Merged
Conversation
GenerateUtils.generateMapCompare built the value array type from mapType.getKeyType instead of getValueType, so the generated comparator read MAP value elements with the key type. For maps whose key and value types differ (e.g. MAP<INT, STRING>) this produced wrong comparison results or a runtime ClassCastException. The sibling generateMultisetCompare and ScalarOperatorGens both pass key and value types separately. Generated-by: Claude Code
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #8762
GenerateUtils.generateMapComparebuilt the value array type frommapType.getKeyTypeinstead ofgetValueType, so the generated comparator readMAPvalue elements with the key type.MAP<INT, STRING>) this gave a wrong comparison result or a runtimeClassCastException.generateMultisetCompareandScalarOperatorGens.generateMapComparisonalready pass key and value types separately.Tests
CodeGenUtilsTest#testMapComparatorComparesValuesWithValueTypecomparingMAP<INT, STRING>rows with equal keys and differing values; it fails (ClassCastException) before the fix and passes after.mvn -pl paimon-core -Dtest=CodeGenUtilsTest test— 15 tests passed (JDK 11).mvn -pl paimon-codegen,paimon-core spotless:checkpassed.