[core] Refactor row ID reassignment manifest processing - #8887
Merged
JingsongLi merged 4 commits intoJul 28, 2026
Conversation
JingsongLi
marked this pull request as ready for review
July 28, 2026 08:13
leaves12138
reviewed
Jul 28, 2026
leaves12138
left a comment
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Found one compilation issue in the latest update.
| assertThat(actual.externalPathDir()).isEqualTo(expected.externalPathDir()); | ||
| assertThat(actual.hasFirstRowId()).isTrue(); | ||
| assertThat(actual.firstRowId()).isEqualTo(10L); | ||
| assertThat(actual.firstRowIdValue()).isEqualTo(10L); |
Contributor
There was a problem hiding this comment.
firstRowIdValue() was removed from BinaryDataFileMeta in the latest commit, but this assertion still calls it, so paimon-core fails during test compilation. Please switch this to actual.nonNullFirstRowId() (or restore the helper).
leaves12138
approved these changes
Jul 28, 2026
leaves12138
left a comment
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Rechecked the latest changes. The compilation issue is fixed, the manifest field projections remain consistent, and the focused core tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
DataEvolutionRowIdReassignerinto a focused planner.BinaryManifestEntryandBinaryDataFileMetaviews.Why
The row-ID reassignment implementation introduced in #8882 combines orchestration, planning state, binary manifest decoding, and compact data structures in one large class. This makes the algorithm difficult to review and gives its inline binary decoding logic a schema that is specific to one caller.
The extracted binary views make projection handling reusable and keep the planner focused on row-ID assignment.
Impact
This is an internal refactor. Row-ID assignment behavior and manifest serialization remain unchanged. Accessors for projected fields implement the existing
ManifestEntryandDataFileMetacontracts; access to fields that were not projected fails explicitly.Validation
56 tests passed. Checkstyle, Spotless, and Enforcer passed.