[rest] Preserve custom catalog for dependency reads - #8912
Merged
leaves12138 merged 1 commit intoJul 29, 2026
Conversation
leaves12138
marked this pull request as ready for review
July 29, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow up on the post-merge review of #8823 and preserve custom REST Catalog
implementations during dependency reads.
Root cause
Dependency reads may reconstruct a catalog through
CatalogFactoryusing aderived
CatalogContext. #8823 populatedmetastore=restso directlyconstructed REST catalogs without a metastore option would not fall back to the
filesystem catalog.
That fallback was applied unconditionally, so a custom REST Catalog such as
metastore=custom-restwas replaced with the built-in REST Catalog identifier.Changes
metastore=restonly when the derived context has no metastore option.Directly constructed built-in REST catalogs continue to receive the
restfallback, while custom REST Catalog factories are reconstructed through their
original identifier.
Validation
mvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -DwildcardSuites=none '-Dtest=CatalogEnvironmentTest,BlobDescriptorReaderFactoryTest,MockRESTCatalogTest#testReadViaHeaderOnDependencyTableAndDataTokenRequests' test(11 tests passed)
mvn -pl paimon-core -DskipTests test-compilegit diff --check