Skip to content

[hive] Strip newline characters from Glue column comments - #8918

Open
0dunay0 wants to merge 1 commit into
apache:masterfrom
0dunay0:fix/glue-column-comments-newlines
Open

[hive] Strip newline characters from Glue column comments#8918
0dunay0 wants to merge 1 commit into
apache:masterfrom
0dunay0:fix/glue-column-comments-newlines

Conversation

@0dunay0

@0dunay0 0dunay0 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Closes #8917

What

Normalize Glue column comments by replacing newline characters with spaces before the 255-character length check. Short multiline comments now get sanitized instead of returning early with raw newlines.

Why

AWS Glue rejects column comments containing newline characters. The previous implementation only truncated long comments and skipped newline cleanup for short ones, which made short multiline comments fail validation.

Tests

  • Added coverage for newline-containing short and long comments in IcebergHiveMetadataCommitterTest
  • Verified with mvn -pl paimon-hive/paimon-hive-catalog -am -Pfast-build -DfailIfNoTests=false -DwildcardSuites=none -Dtest=IcebergHiveMetadataCommitterTest test

The targeted Maven run passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Glue column comments with newlines are not normalized before length check

1 participant