[common] Preserve empty scored results during serialization - #8924
Merged
Conversation
GlobalIndexResultSerializer inferred the result type from the score count, so empty scored results were deserialized as unscored and failed scored-result callers. Add an explicit result kind in serialization version 2, retain version 1 read compatibility, and cover empty scored round trips and legacy payloads. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
GlobalIndexResultSerializerinferred the result type from the score count. Empty scored and unscored results both have zero scores, so round trips and copies lost theScoredGlobalIndexResulttype.Introduce serialization version 2 with an explicit result kind, retain version 1 read compatibility, and add regression coverage for empty scored results and legacy payloads.
Tests
GlobalIndexSerDeUtilsTestSparkDataEvolutionVectorReadTestFlinkDataEvolutionVectorReadTest