Skip to content

[core] Fix scan from tag on branch table. - #9044

Merged
JingsongLi merged 1 commit into
apache:masterfrom
Stephen0421:fix-branch-scan-tag
Aug 5, 2026
Merged

[core] Fix scan from tag on branch table.#9044
JingsongLi merged 1 commit into
apache:masterfrom
Stephen0421:fix-branch-scan-tag

Conversation

@Stephen0421

Copy link
Copy Markdown
Contributor

Purpose

Fix batch read from tag on branch tables. StaticFromTagStartingScanner creates TagManager without branch name, so tags that exist only on a branch cannot be resolved and reads with scan.tag-name fail with Tag doesn't exist.

Pass snapshotManager.branch() when creating TagManager, consistent with AbstractBatchTableScan, AbstractDataTableScan, and IncrementalDiffStartingScanner.

Test

  • Add testGetSnapshotFromBranchTag and testScanFromBranchTag in StaticFromTagStartingScannerTest

@JingsongLi JingsongLi closed this Aug 5, 2026
@JingsongLi JingsongLi reopened this Aug 5, 2026
@JingsongLi JingsongLi closed this Aug 5, 2026
@JingsongLi JingsongLi reopened this Aug 5, 2026
@JingsongLi JingsongLi closed this Aug 5, 2026
@JingsongLi JingsongLi reopened this Aug 5, 2026

@JingsongLi JingsongLi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi
JingsongLi merged commit 5321706 into apache:master Aug 5, 2026
19 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants