[python] Inherit watermark in PyPaimon commits - #9090
Merged
JingsongLi merged 1 commit intoAug 7, 2026
Merged
Conversation
JingsongLi
marked this pull request as ready for review
August 7, 2026 05:56
leaves12138
approved these changes
Aug 7, 2026
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the watermark inheritance semantics against the Java commit path and the PyPaimon retry flow. The change correctly preserves the latest snapshot watermark while keeping it absent for histories without one. Targeted commit tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make PyPaimon commits inherit the watermark from the latest snapshot.
Why
Paimon snapshots may omit the watermark only when neither the current commit nor the previous snapshot has one. PyPaimon currently creates every new snapshot without copying the latest watermark, which breaks watermark continuity in mixed Java/Python write histories and can invalidate watermark-based time travel.
Impact
After this change, a PyPaimon commit following a watermark-bearing Java/Flink snapshot preserves that watermark. Tables whose history has never carried a watermark continue to write snapshots without one.
Tests
python3 -m pytest pypaimon/tests/file_store_commit_test.py -qpython3 -m pytest pypaimon/tests/reader_append_only_test.py::AoReaderTest::test_commit_retry_filter -qflake8 --config=./dev/cfg.ini pypaimon/write/file_store_commit.py pypaimon/tests/file_store_commit_test.pygit diff --check