[spark] Remove upsert-key support - #9093
Merged
Merged
Conversation
JingsongLi
marked this pull request as ready for review
August 7, 2026 07:30
leaves12138
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove the Spark
upsert-keytable property and its automaticINSERT INTOtoMERGE INTOrewrite. It's just syntactic sugar; we shouldn't provide it because it has a lot of ambiguity with primary key tables.This change removes the option and accessor from
CoreOptions, the associated schema validation, the Spark analyzer rule and registration, and the Spark 3.2 through 4.1 tests. It also removes the SQL Upsert documentation, navigation entry, redirect, and generated configuration entry.Existing tables that specify
upsert-keywill no longer receive the automatic Spark upsert rewrite. The independent PyPaimon Data Evolutionupsert_by_keyAPI is not affected.Tests
mvn -pl paimon-core -Pfast-build -DwildcardSuites=none -Dtest=SchemaValidationTest testmvn -pl paimon-spark/paimon-spark-ut -am -Pfast-build -Pspark3 -DskipTests compileJAVA_HOME=<jdk17> mvn -pl paimon-spark/paimon-spark-ut -am -Pfast-build -Pspark4 -DskipTests compilemvn -pl paimon-api,paimon-core,paimon-spark/paimon-spark-common -Pspark3 -DskipTests spotless:check