Skip to content

[lance] Reject unsupported element types nested in ARRAY #9102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackylee-ch wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −1
Open

[lance] Reject unsupported element types nested in ARRAY #9102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paimon-lance/src/main/java/org/apache/paimon/format/lance/LanceFileFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ public Void visit(BlobType blobType) {

@Override
public Void visit(ArrayType arrayType) {
return null;
return arrayType.getElementType().accept(this);
}

@Override
Expand Down
16 changes: 16 additions & 0 deletions paimon-lance/src/test/java/org/apache/paimon/format/lance/LanceFileFormatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,22 @@ public void testValidateDataFields_UnsupportedMultisetType() {
assertThrows(UnsupportedOperationException.class, () -> format.validateDataFields(rowType));
}

@Test
public void testValidateDataFields_UnsupportedTypeNestedInArray() {
LanceFileFormat format =
new LanceFileFormat(new FileFormatFactory.FormatContext(new Options(), 1024, 1024));
RowType rowType = RowType.of(DataTypes.ARRAY(DataTypes.MULTISET(DataTypes.STRING())));
assertThrows(UnsupportedOperationException.class, () -> format.validateDataFields(rowType));
}

@Test
public void testValidateDataFields_SupportedTypeNestedInArray() {
LanceFileFormat format =
new LanceFileFormat(new FileFormatFactory.FormatContext(new Options(), 1024, 1024));
RowType rowType = RowType.of(DataTypes.ARRAY(DataTypes.ARRAY(DataTypes.INT())));
assertDoesNotThrow(() -> format.validateDataFields(rowType));
}

@Test
public void testValidateDataFields_SupportedTypes() {
LanceFileFormat format =
Expand Down
Loading