Skip to content

[core] Reject Variant type for primary key and partition key - #9105

Open
ArnavBalyan wants to merge 1 commit into
apache:masterfrom
ArnavBalyan:arnavb/rej-variant
Open

[core] Reject Variant type for primary key and partition key#9105
ArnavBalyan wants to merge 1 commit into
apache:masterfrom
ArnavBalyan:arnavb/rej-variant

Conversation

@ArnavBalyan

Copy link
Copy Markdown
Member

Purpose

  • Table creation with variant primary key passes validation today
  • Variant has no comparator case in codegen, keys built with it fail at runtime. Ensure we can detect it similar to Map and array at table creation and fail the creation with variant key for safety.
  • Add VariantType to blacklist of logical types, so variant keys are rejected at create time.

Tests

  • UT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant